Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there interest in adding option for beginning padding to ggml_pad? #861

Open
balisujohn opened this issue Jun 17, 2024 · 1 comment
Open

Is there interest in adding option for beginning padding to ggml_pad? #861

balisujohn opened this issue Jun 17, 2024 · 1 comment

Comments

@balisujohn
Copy link
Contributor

balisujohn commented Jun 17, 2024 •
edited

right now ggml_padonly supports putting padding at the end of each dimension. Is there support for generalizing it to allow adding padding at at the beginning of each dimension? My thinking is the arguments would be

p00,p01,p10,p11,p20,p21,p30,p31

This is necessary for tortoise.cpp so as usual I'll be implementing it anyway and am happy to upstream it.
@balisujohn balisujohn changed the title is there interest in adding option for beginning padding to ggml_pad Is there interest in adding option for beginning padding to ggml_pad? Jun 17, 2024
@ggerganov
Copy link
Owner

Yes, make sure to extend the existing kerenels and not introduce new ones. The ggml API can keep ggml_pad and also add ggml_pad_ext with the full parameter list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ggerganov @balisujohn