Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License for Python-based GGUF parser with NumPy vectorization #802

Closed
99991 opened this issue Apr 21, 2024 · 2 comments
Closed

License for Python-based GGUF parser with NumPy vectorization #802

99991 opened this issue Apr 21, 2024 · 2 comments

Comments

@99991
Copy link

99991 commented Apr 21, 2024

I have implemented a Python-based parser for GGUF with NumPy vectorization and was not sure in how far it should be considered a derivative work, since the implementation is substantially different, but of course the data layout has to be the same. Compare e.g. dequantize_row_q3_K

https://github.com/ggerganov/ggml/blob/fca1caafea7de9fbd7efc733b9818f9cf2da3050/src/ggml-quants.c#L1723C32-L1723C42

with dequantize_q3_k

https://github.com/99991/pygguf/blob/ce1dcea6ff189e3d83b62f5604e6f4d2de548a4d/gguf.py#L141

Anyway, I just wanted to ask you if you are alright with this license, or if I should change anything.

https://github.com/99991/pygguf/blob/ce1dcea6ff189e3d83b62f5604e6f4d2de548a4d/LICENSE#L3

@ggerganov
Copy link
Owner

Yes, it is good - no worries

@99991
Copy link
Author

99991 commented Apr 25, 2024

Excellent! Thank you!

@99991 99991 closed this as completed Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants