-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ggml : make ggml_fp16_t private #720
Labels
refactoring
Refactoring
Comments
We could probably define it to |
Ah yes, doing so would make this change much simpler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the
ggml_fp16_t
typedef is exposed in the public API:ggml/include/ggml/ggml.h
Lines 317 to 332 in 6b14d73
Since this type is platform specific, it would make sense to hide it by moving it in
ggml-impl.h
.We will still expose an API for F16 <-> F32 conversions, but it sill operate on
void *
instead ofggml_fp16_t
The text was updated successfully, but these errors were encountered: