Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"array size is too large" on model load #714

Closed
iamlemec opened this issue Jan 29, 2024 · 1 comment · Fixed by #715
Closed

"array size is too large" on model load #714

iamlemec opened this issue Jan 29, 2024 · 1 comment · Fixed by #715

Comments

@iamlemec
Copy link
Contributor

I think the bounds check in the recent commit #709 is backwards, specifically at

ggml/src/ggml.c

Line 19438 in b2a5c34

if (kv->value.arr.n < SIZE_MAX/sizeof(struct gguf_str)) {

and the one before it. I'm getting "array size is too large" when trying to load a model with the vocab list included.

@ggerganov
Copy link
Owner

Sorry about that - will fix it in a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants