Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ggml_cpy_inplace and ggml_cont_inplace #622

Closed
slaren opened this issue Nov 27, 2023 · 1 comment · Fixed by #693
Closed

ggml_cpy_inplace and ggml_cont_inplace #622

slaren opened this issue Nov 27, 2023 · 1 comment · Fixed by #693

Comments

@slaren
Copy link
Collaborator

slaren commented Nov 27, 2023

I was wondering what is the purpose of these operations. From what I can tell:

  • ggml_cpy_inplace only disables grads
  • ggml_cont_inplace cannot be implemented correctly, since it would cause values that will be needed later to be overwritten

Should these be removed?
@ggerganov
Copy link
Owner

Yup, I think should be removed

CCLDArjun pushed a commit to CCLDArjun/ggml that referenced this issue Dec 18, 2023
@ggerganov
ggml : fix NEON signs (close ggerganov#620, ggerganov#622)
77efdf5
4imothy added a commit to 4imothy/ggml that referenced this issue Jan 11, 2024
@4imothy
remove ggml_cpy_inplace and ggml_cont_inplace, close ggerganov#622
f976bff
@4imothy 4imothy mentioned this issue Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove ggml_cpy_inplace and ggml_cont_inplace, close ggerganov#622 4imothy/ggml
2 participants
@ggerganov @slaren