Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-conv-transpose fails when building with sanitizers enabled #589

Closed
slaren opened this issue Oct 21, 2023 · 0 comments · Fixed by #591
Closed

test-conv-transpose fails when building with sanitizers enabled #589

slaren opened this issue Oct 21, 2023 · 0 comments · Fixed by #591
Labels
bug Something isn't working

Comments

@slaren
Copy link
Collaborator

slaren commented Oct 21, 2023

Not sure if this is something specific to my machine or a compiler bug, but I noticed that when building with sanitizers test-conv-transpose fails.

With sanitizers
$ rm -fr build; cmake -S . -B build -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_BUILD_TYPE=Debug -DGGML_SANITIZE
_ADDRESS=ON -DGGML_SANITIZE_UNDEFINED=ON
-- The C compiler identification is GNU 12.3.0
-- The CXX compiler identification is GNU 12.3.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found Git: /usr/bin/git (found version "2.39.2")
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- CMAKE_SYSTEM_PROCESSOR: x86_64
-- x86 detected
-- Linux detected
-- x86 detected
-- Linux detected
-- Configuring done
-- Generating done
-- Build files have been written to: /home/diego/code/ggml/build

$ cmake --build build -t test-conv-transpose && build/bin/test-conv-transpose
[ 50%] Building C object src/CMakeFiles/ggml.dir/ggml-backend.c.o
[ 50%] Building C object src/CMakeFiles/ggml.dir/ggml-alloc.c.o
[ 50%] Building C object src/CMakeFiles/ggml.dir/ggml.c.o
[ 66%] Linking C shared library libggml.so
[ 66%] Built target ggml
[ 83%] Building C object tests/CMakeFiles/test-conv-transpose.dir/test-conv-transpose.c.o
[100%] Linking C executable ../bin/test-conv-transpose
[100%] Built target test-conv-transpose
GGML_ASSERT: /home/diego/code/ggml/tests/test-conv-transpose.c:55: expected == actual
fish: Job 1, 'build/bin/test-conv-transpose' terminated by signal SIGABRT (Abort)
Without sanitizers
$ rm -fr build; cmake -S . -B build -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_BUILD_TYPE=Debug
-- The C compiler identification is GNU 12.3.0
-- The CXX compiler identification is GNU 12.3.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found Git: /usr/bin/git (found version "2.39.2")
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- CMAKE_SYSTEM_PROCESSOR: x86_64
-- x86 detected
-- Linux detected
-- x86 detected
-- Linux detected
-- Configuring done
-- Generating done
-- Build files have been written to: /home/diego/code/ggml/build

$ cmake --build build -t test-conv-transpose && build/bin/test-conv-transpose
[ 16%] Building C object src/CMakeFiles/ggml.dir/ggml.c.o
[ 33%] Building C object src/CMakeFiles/ggml.dir/ggml-alloc.c.o
[ 50%] Building C object src/CMakeFiles/ggml.dir/ggml-backend.c.o
[ 66%] Linking C shared library libggml.so
[ 66%] Built target ggml
[ 83%] Building C object tests/CMakeFiles/test-conv-transpose.dir/test-conv-transpose.c.o
[100%] Linking C executable ../bin/test-conv-transpose
[100%] Built target test-conv-transpose
@ggerganov ggerganov added the bug Something isn't working label Oct 22, 2023
@slaren slaren linked a pull request Oct 24, 2023 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants