Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Parameter parsing #391

Merged
merged 2 commits into from
Jul 23, 2023
Merged

Fix: Parameter parsing #391

merged 2 commits into from
Jul 23, 2023

Conversation

rezaarezvan
Copy link
Contributor

@rezaarezvan rezaarezvan commented Jul 15, 2023 •
edited
Loading

Fixes #331

Since the handling of empty parameters was not in place - this PR will fix this. I've added a simple helper function that checks if the input parameters are valid (non-empty).

@rezaarezvan rezaarezvan marked this pull request as ready for review July 17, 2023 17:01
@ggerganov ggerganov merged commit f1c5a11 into ggerganov:master Jul 23, 2023
@rezaarezvan rezaarezvan deleted the rezvan/fix_params branch July 24, 2023 08:24
@rezaarezvan rezaarezvan changed the title Fix: Parameter parsing [WIP] Fix: Parameter parsing Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

minor issue: segmentation fault bin/starcoder --seed
2 participants
@rezaarezvan @ggerganov