ggml : add ggml_map_custom1-3 #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Possible issue: the data type of the destination tensor is copied from the data type of the first parameter. In some cases, users may want to use a different data type. We could add a |
ggerganov
approved these changes
Jul 31, 2023
|
Sure, adding type argument sounds good. But even as it is it should work for most use cases |
|
I guess it is better to test this for a while and make sure that it works for the users. Adding another version of the ops that adds a parameter to choose the output type would be trivial and can be done later, and I think that would be better than adding even more parameter to these functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #294
ggml_map_custom1-3and_inplaceversionsggml_map_unary_f32,ggml_map_binary_f32,ggml_map_custom1-3_f32as deprecatedtests/test-customop.cto test these functions and hopefully also serve as an exampleAdditional changes:
GGML_TYPE_F32type checks fromggml_map_custom1-3_f32ggml_are_same_shapepublic.editorconfigfromllama.cppGGML_DEPRECATEDtoggml.h(fromllama.h)