-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ggml : reduce the values of ggml_op
enum
#285
Labels
Comments
ggml_op
enum
bump (description updated) |
@ggerganov, it appears you did this already in 5b2b2dc. I recommend closing this issue. |
Oh never mind, I am looking at issues that are already completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Here is another idea to consider for reducing the amount of unary ops and code duplication in
ggml.c
:The following ops:
Can all become:
Original task (completed via #313)
Certain
ggml
operators can be combined into a singe operator with extra arguments.For example:
GGML_OP_CONV_1D_S1_PH
GGML_OP_CONV_1D_S2_PH
can all become:
GGML_OP_CONV_1D
with a signature of:
Internally, we can have custom implementations of
ggml_compute_forward_conv_1d()
for specific values of the parameters andGGML_ASSERT
for everything else that is not supported.This will allow to extend the functionality of these operator more easily in the future
The text was updated successfully, but these errors were encountered: