examples : add tokenization tests and refactor codes #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on affects other models
…ly supported models
klosax
reviewed
May 23, 2023
examples/common.cpp
Outdated
Comment on lines
239
to
240
| std::wstring text_multibytes = convert_to_wstring(text); | ||
| std::string utf8conv = convert_to_utf8(text_multibytes); |
…truct, tokenization method) defined in its main.cpp
ggerganov
requested changes
May 24, 2023
ggerganov
reviewed
May 24, 2023
ggerganov
requested changes
May 24, 2023
…e path from 'test_gpt_tokenizer' function
…enzation and decoding)
ggerganov
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(An attempt to fix #170)
examples : test tokenization + support utf-8 and multi-byte encodings + refactor gpt_tokenize + refactor convert-h5-to-ggml.py