Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpine-based docker image #609

Merged
merged 2 commits into from
Jan 30, 2020
Merged

Conversation

ikedam
Copy link
Contributor

@ikedam ikedam commented Jan 18, 2020

Replaces #604 .

I want alpine-based docker images for sops, as it's small and easy to use:

  • The current image uses 2 GB+:
    $ docker images mozilla/sops
    REPOSITORY          TAG                 IMAGE ID            CREATED             SIZE
    mozilla/sops        latest              6a8e325d2d11        5 weeks ago         2.3GB
    
  • The alpine-based image uses only 65MB:
    $ docker build -t sops -f Dockerfile.alpine .
    ...
    $ docker images sops
    REPOSITORY          TAG                 IMAGE ID            CREATED              SIZE
    sops                latest              c4f6175388ce        About a minute ago   64.4MB
    

And this pull request also changes .circleci/config.yml to deploy alpine based images as mozilla/sops:3.5.0-alpine and mozilla/sops:alpine.
I believe we don't need alpine images for every commits and only images for tags are enough useful.

- build:
filters:
tags:
only: /.*/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to use workflow to have circleci run also for tags.

@codecov-io
Copy link

codecov-io commented Jan 18, 2020

Codecov Report

Merging #609 into develop will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #609      +/-   ##
===========================================
+ Coverage    36.98%   37.15%   +0.17%     
===========================================
  Files           21       21              
  Lines         2893     2893              
===========================================
+ Hits          1070     1075       +5     
+ Misses        1728     1724       -4     
+ Partials        95       94       -1
Impacted Files Coverage Δ
stores/flatten.go 91.52% <0%> (+4.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1634350...31d62bc. Read the comment docs.

Copy link
Contributor

@autrilla autrilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mostly, but I think you should probably merge this into #607

…sops:vX.X-alpine", "mozilla/sops:vX-alpine", and "mozilla/sops:alpine"
@ikedam
Copy link
Contributor Author

ikedam commented Jan 26, 2020

@autrilla Thank you, I rebased this to the latest develop and reworked based on #607.

@autrilla autrilla merged commit f7e880b into getsops:develop Jan 30, 2020
@autrilla
Copy link
Contributor

Thanks for working on this :)

@ikedam
Copy link
Contributor Author

ikedam commented Jan 30, 2020

Thanks!

rochaporto pushed a commit to rochaporto/sops that referenced this pull request Jun 22, 2020
* Add Dockerfile.alpine

* Publish alpine containers as "mozilla/sops:vX.X.X-alpine",  "mozilla/sops:vX.X-alpine",  "mozilla/sops:vX-alpine",  and "mozilla/sops:alpine"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants