Fix failing Vault test; update aws-sdk-go to v1.23.13

[jessebye]

Resolves #572

[autrilla]

--- FAIL: TestLoadConfigFileWithVaultDestinationRules (0.00s)
    config_test.go:326: 
        	Error Trace:	config_test.go:326
        	Error:      	Not equal: 
        	            	expected: "https://127.0.0.1:8200/v1/secret/data/foobar/barfoo"
        	            	actual  : "https://127.0.0.1:8200/v1/secret/data/foobar/barfoo"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-https://127.0.0.1:8200/v1/secret/data/foobar/barfoo
        	            	+https://127.0.0.1:8200/v1/secret/data/foobar/barfoo
        	Test:       	TestLoadConfigFileWithVaultDestinationRules
    config_test.go:330: 
        	Error Trace:	config_test.go:330
        	Error:      	Not equal: 
        	            	expected: "https://127.0.0.1:8200/v1/kv/barfoo/barfoo"
        	            	actual  : "https://127.0.0.1:8200/v1/kv/barfoo/barfoo"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-https://127.0.0.1:8200/v1/kv/barfoo/barfoo
        	            	+https://127.0.0.1:8200/v1/kv/barfoo/barfoo
        	Test:       	TestLoadConfigFileWithVaultDestinationRules
FAIL

heh.

[jessebye]

@autrilla darn. So something between how the tests are run in CI and how they are run locally is not consistent. Should I just roll back my change to the test for now?

[autrilla]

Yes, I think I figured out what! CI sets export VAULT_ADDR='https://127.0.0.1:8200', which the Vault SDK then uses for the new connections, even in tests.

@ajvb what do you think we should do about this? I'd say we should run the tests with no environment variables.

[jessebye]

Aha, I see that now. I updated the URL in the CI config... does that sound OK?

[autrilla]

Aha, I see that now. I updated the URL in the CI config... does that sound OK?

I think that's going to fail the tests as the Vault tests server isn't set up for https. I think you should just revert any of those changes so CI still passes, and only make them locally to make sure your tests pass there. We'll figure out what to do to fix this inconsistency later.

[codecov-io]

Codecov Report

Merging #573 into develop will increase coverage by 0.17%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #573      +/-   ##
===========================================
+ Coverage    36.94%   37.11%   +0.17%     
===========================================
  Files           21       21              
  Lines         2891     2891              
===========================================
+ Hits          1068     1073       +5     
+ Misses        1728     1724       -4     
+ Partials        95       94       -1

Impacted Files	Coverage Δ
stores/flatten.go	91.52% <0%> (+4.23%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 200322d...b4135e4. Read the comment docs.

[jessebye]

Aaaaand it passes!

[jessebye]

@autrilla what's the release cycle look like for a change like this? we're blocked by this currently, would be awesome even if we had to pull in a beta build of SOPS to keep moving.

[autrilla]

Great, thanks for the patch!

[autrilla]

@autrilla what's the release cycle look like for a change like this? we're blocked by this currently, would be awesome even if we had to pull in a beta build of SOPS to keep moving.

We don't have a set release cycle. For now the quickest way is probably for you to build your own binary and distribute it. It might be good to set up CI to automatically publish assets for develop and master.