Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(alerts): Remove activated alerts from rule endpoints #81285

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ceorourke
Copy link
Member

@ceorourke ceorourke commented Nov 26, 2024

Another chunk of #81095 that removes the alert rule endpoint code for activated alerts.

This can't be merged until #81218 is merged.

Draft because removing this stuff from create_alert_rule breaks all tests that passed activation stuff. Might have to rethink this one.

@ceorourke ceorourke requested a review from a team as a code owner November 26, 2024 00:11
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

❌ 71 Tests Failed:

Tests completed Failed Passed Skipped
20737 71 20666 207
View the top 3 failed tests by shortest run time
tests.sentry.incidents.models.test_alert_rule.AlertRuleTest::test_conditionally_subscribing_project_initializes_activation
Stack Traces | 1.73s run time
#x1B[1m#x1B[.../incidents/models/test_alert_rule.py#x1B[0m:208: in test_conditionally_subscribing_project_initializes_activation
    assert len(created_subscriptions) == 1
#x1B[1m#x1B[31mE   assert 0 == 1#x1B[0m
#x1B[1m#x1B[31mE    +  where 0 = len([])#x1B[0m
tests.sentry.incidents.models.test_alert_rule.AlertRuleTest::test_subscribes_projects_to_alert_rule
Stack Traces | 1.81s run time
#x1B[1m#x1B[.../incidents/models/test_alert_rule.py#x1B[0m:155: in test_subscribes_projects_to_alert_rule
    assert mock_bulk_create_snuba_subscriptions.call_count == 0
#x1B[1m#x1B[31mE   AssertionError: assert 1 == 0#x1B[0m
#x1B[1m#x1B[31mE    +  where 1 = <MagicMock name='bulk_create_snuba_subscriptions' id='140632465841264'>.call_count#x1B[0m
tests.sentry.incidents.models.test_alert_rule.AlertRuleTest::test_conditionally_subscribe_project_to_alert_rules
Stack Traces | 1.85s run time
#x1B[1m#x1B[.../incidents/models/test_alert_rule.py#x1B[0m:183: in test_conditionally_subscribe_project_to_alert_rules
    assert len(created_subscriptions) == 1
#x1B[1m#x1B[31mE   assert 0 == 1#x1B[0m
#x1B[1m#x1B[31mE    +  where 0 = len([])#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@ceorourke ceorourke marked this pull request as draft November 26, 2024 22:57
@ceorourke ceorourke removed request for a team November 26, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant