feat(explore): Convert buttons into context menu #81219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle ReportChanges will decrease total bundle size by 173 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #81219 +/- ##
==========================================
+ Coverage 80.33% 80.36% +0.02%
==========================================
Files 7225 7221 -4
Lines 320212 320142 -70
Branches 20781 20782 +1
==========================================
+ Hits 257257 257284 +27
+ Misses 62561 62464 -97
Partials 394 394 |
edwardgou-sentry
approved these changes
Nov 25, 2024
evanh
pushed a commit
that referenced
this pull request
Nov 25, 2024
Convert the buttons for alerts and add to dashboards into a context menu. Shifts over a bunch of the code for both the alerts and dashboards buttons into a context menu component that's specific for explore charts. I needed to extract the logic for getting the sort option to a helper function I could use in my callback. This is because visualizes is a list of items and we map over it for charts, meaning I can't use a hook to reference the correct chart at the point of instantiation, it needs to be used in a callback that's defined during that mapping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the buttons for alerts and add to dashboards into a context menu. Shifts over a bunch of the code for both the alerts and dashboards buttons into a context menu component that's specific for explore charts.
I needed to extract the logic for getting the sort option to a helper function I could use in my callback. This is because visualizes is a list of items and we map over it for charts, meaning I can't use a hook to reference the correct chart at the point of instantiation, it needs to be used in a callback that's defined during that mapping.
Screen.Recording.2024-11-22.at.5.18.40.PM.mov