feat(stories): Add RouteAnalyticsContextProvider to stories so we can see what is viewed #81108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… see what is viewed
roggenkemper
approved these changes
Nov 21, 2024
iamrajjoshi
pushed a commit
that referenced
this pull request
Nov 24, 2024
… see what is viewed (#81108) I realized recently that we could have analytics about which story files are most commonly referenced. It would help to know what's used often because it might indicate something that needs more attention, similarly something not referenced might be because it's either intuitive, or unused in new code. This is a half step though. This `RouteAnalyticsContextProvider` used relies on the `react-hook:route-activated` hook provided to the HookStore, in dev that won't be implemented. So the data we collect will only be from people using sentry.io/stories which might not cover everyone.
harshithadurai
pushed a commit
that referenced
this pull request
Nov 25, 2024
… see what is viewed (#81108) I realized recently that we could have analytics about which story files are most commonly referenced. It would help to know what's used often because it might indicate something that needs more attention, similarly something not referenced might be because it's either intuitive, or unused in new code. This is a half step though. This `RouteAnalyticsContextProvider` used relies on the `react-hook:route-activated` hook provided to the HookStore, in dev that won't be implemented. So the data we collect will only be from people using sentry.io/stories which might not cover everyone.
evanh
pushed a commit
that referenced
this pull request
Nov 25, 2024
… see what is viewed (#81108) I realized recently that we could have analytics about which story files are most commonly referenced. It would help to know what's used often because it might indicate something that needs more attention, similarly something not referenced might be because it's either intuitive, or unused in new code. This is a half step though. This `RouteAnalyticsContextProvider` used relies on the `react-hook:route-activated` hook provided to the HookStore, in dev that won't be implemented. So the data we collect will only be from people using sentry.io/stories which might not cover everyone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized recently that we could have analytics about which story files are most commonly referenced. It would help to know what's used often because it might indicate something that needs more attention, similarly something not referenced might be because it's either intuitive, or unused in new code.
This is a half step though. This
RouteAnalyticsContextProviderused relies on thereact-hook:route-activatedhook provided to the HookStore, in dev that won't be implemented. So the data we collect will only be from people using sentry.io/stories which might not cover everyone.