Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hydration Errors] Replace HTML Diff tab #80092

Open
c298lee opened this issue Oct 31, 2024 · 3 comments
Open

[Hydration Errors] Replace HTML Diff tab #80092

c298lee opened this issue Oct 31, 2024 · 3 comments

Comments

@c298lee
Copy link
Member

c298lee commented Oct 31, 2024

@corbie1
Copy link

corbie1 commented Nov 7, 2024

Image
the tree doesn't fit through the window

@getsantry
Copy link
Contributor

getsantry bot commented Nov 12, 2024

Routing to @getsentry/product-owners-replays for triage ⏲️

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Nov 12, 2024
@ryan953
Copy link
Member

ryan953 commented Nov 12, 2024

@corbie1 thanks for catching that, I just put up #80581 to fix it!

FYI we're looking for any feedback on whether that text diff is useful or not, and in what cases. As you can tell we haven't put a full amount of effort into this thing yet... one reason for that is there seems to be formatting changes that appear in the text diff which do not cause a hydration error, but do make the diff noisy. So if you have examples where this was helpful despite the implementation issues lmk!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

4 participants