Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump (or allow) sentry libraries to version 4 #782

Closed
tacman opened this issue Nov 20, 2023 · 5 comments
Closed

Bump (or allow) sentry libraries to version 4 #782

tacman opened this issue Nov 20, 2023 · 5 comments

Comments

@tacman
Copy link

tacman commented Nov 20, 2023

Problem Statement

This bundle doesn't use (or allow) the latest sentry libraries.

Solution Brainstorm

https://github.com/getsentry/sentry-symfony/blob/master/composer.json#L30C30-L31C1

This might be as simple as change composer.json to

 "sentry/sdk": "^3.4 || ^4.0",
 "sentry/sentry": "^3.20.1 || ^4.0",
@glennmcewan
Copy link

I've found an issue this morning which is related to sentry/sentry-php:
getsentry/sentry-php#1503

The IgnoreErrorsIntegration has been removed in v4, and this bundle did the opposite of that for its v4 release:
#385

It wouldn't be a simple change to the composer.json.

@tacman
Copy link
Author

tacman commented Nov 20, 2023

Would bumping the minimum PHP to 7.4 (which is already at EOL) or 8.0 help? The issue you referenced mentioned something about a change between 7.2 and 7.3. PHP 7.2 has been EOL for 3 years.

@cleptric
Copy link
Member

Would bumping the minimum PHP to 7.4 (which is already at EOL) or 8.0 help? The issue you referenced mentioned something about a change between 7.2 and 7.3. PHP 7.2 has been EOL for 3 years.

No, it would not, and we won't do this.

https://github.com/getsentry/sentry-php/releases/tag/4.0.0
Here is the link to the changelog. Bumping the SDK will introduce many breaking changes to userland code, outside of the Symfony SDK, hence we have to release version 5.0.0 of this SDK as well.

@glennmcewan
Copy link

glennmcewan commented Nov 20, 2023

Without derailing this too much, no. It's an old issue sure but that class has been removed in the core SDK, so this repo would need to make some changes to handle the deprecations.

Edit: what @cleptric said

@cleptric
Copy link
Member

We'll tackle the SDK update in #783, closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants