Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry unable to scrub sensitive infomation in in case of raw body #948

Closed
rishabhsairawat opened this issue Jan 17, 2020 · 2 comments · Fixed by #984
Closed

Sentry unable to scrub sensitive infomation in in case of raw body #948

rishabhsairawat opened this issue Jan 17, 2020 · 2 comments · Fixed by #984
Assignees
Projects
Milestone

Comments

@rishabhsairawat
Copy link

I have mentioned the password as a sensitive field in the configuration. But In case of invalid JSON, the sentry is sending the password as plain-text to server.

ActionDispatch::Http::Parameters::ParseError: 822: unexpected token at '{
"username":"abc.pqr",
"role": "admin"
"password": "Abc@123"
}'
@thtonon
Copy link

thtonon commented Feb 18, 2020

Any news on this issue? I'm having the same problem

@st0012 st0012 added this to Needs triage in 3.x Aug 6, 2020
@st0012
Copy link
Collaborator

st0012 commented Aug 14, 2020

thanks for reporting this issue, I've opened #984 for solving it. would you mind using

gem 'sentry-raven', github: "getsentry/raven-ruby", branch: "fix-#948"

to give it a try?

@st0012 st0012 added this to the 3.0.1 milestone Aug 14, 2020
@st0012 st0012 self-assigned this Aug 14, 2020
@st0012 st0012 moved this from Needs triage to High priority in 3.x Aug 14, 2020
3.x automation moved this from High priority to Closed Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3.x
  
Closed
Development

Successfully merging a pull request may close this issue.

3 participants