Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masking cookies as key/pair instead of a single string #983

Merged
merged 1 commit into from
Aug 13, 2020
Merged

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Aug 13, 2020

This closes #900 and #904

@st0012 st0012 added the bug fix label Aug 13, 2020
@st0012 st0012 added this to the 3.0.1 milestone Aug 13, 2020
@st0012 st0012 self-assigned this Aug 13, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2020

Codecov Report

Merging #983 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #983   +/-   ##
=======================================
  Coverage   97.35%   97.35%           
=======================================
  Files          46       46           
  Lines        2080     2080           
=======================================
  Hits         2025     2025           
  Misses         55       55           
Impacted Files Coverage Δ
spec/raven/processors/cookies_spec.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9d150e...1bb8d45. Read the comment docs.

@st0012 st0012 merged commit 5d5ea3b into master Aug 13, 2020
@st0012 st0012 added this to Closed in 3.x via automation Aug 13, 2020
@st0012 st0012 deleted the fix-#900 branch August 13, 2020 17:11
@st0012 st0012 mentioned this pull request Aug 14, 2020
@st0012 st0012 moved this from Closed to v3.0.1 in 3.x Aug 14, 2020
@st0012 st0012 moved this from v3.0.1 to Closed in 3.x Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
3.x
  
Closed
Development

Successfully merging this pull request may close these issues.

request.cookies: Discarded invalid value
2 participants