Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support/deal with DebugExceptions interceptors #826

Closed
nateberkopec opened this issue Apr 20, 2018 · 5 comments
Closed

Support/deal with DebugExceptions interceptors #826

nateberkopec opened this issue Apr 20, 2018 · 5 comments

Comments

@nateberkopec
Copy link
Contributor

https://github.com/rails/rails/pull/23868/files

@st0012 st0012 added this to the 4.0.0 milestone Aug 27, 2020
@st0012 st0012 added this to To do in 4.x via automation Aug 27, 2020
@st0012 st0012 added the rails label Aug 27, 2020
@st0012 st0012 modified the milestones: 4.0.0, 4.1.0, 4.2.0 Dec 10, 2020
@st0012 st0012 modified the milestones: 4.2.0, 4.3.0, sentry-rails-4.1.7 Jan 30, 2021
@st0012
Copy link
Collaborator

st0012 commented Jan 30, 2021

@nateberkopec wow this actually handles rescued exceptions more elegantly (no more patching needed). thanks for leaving this trace 👍

@st0012
Copy link
Collaborator

st0012 commented Jan 30, 2021

turns out it's added to Rails 6 only 🤦‍♂️

@st0012 st0012 removed this from the sentry-rails-4.1.7 milestone Jan 30, 2021
@github-actions
Copy link

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@st0012 st0012 removed this from To do in 4.x Jan 27, 2022
@st0012 st0012 added this to To do in 5.x via automation Jan 27, 2022
@st0012 st0012 added this to the 6.0.0 milestone Jan 27, 2022
@st0012 st0012 removed this from the 6.0.0 milestone Oct 23, 2022
@st0012 st0012 removed this from To do in 5.x Oct 23, 2022
@sl0thentr0py
Copy link
Member

@st0012 I believe we already handle this? can I close?

@st0012
Copy link
Collaborator

st0012 commented Feb 13, 2023

No we haven't handled this. But with the new exception reporter in Rails 7.0+, I also won't proceed on this one anymore.
So I'll close it as not planned.

@st0012 st0012 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants