Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer to disk #745

Closed
nateberkopec opened this issue Aug 15, 2017 · 3 comments
Closed

Buffer to disk #745

nateberkopec opened this issue Aug 15, 2017 · 3 comments

Comments

@nateberkopec
Copy link
Contributor

Ability to write events to disk when network (or Sentry) is down and replay them later.

@st0012 st0012 added this to the 4.0.0 milestone Aug 14, 2020
@st0012 st0012 added this to To do in 4.x via automation Aug 14, 2020
@st0012 st0012 modified the milestones: 4.0.0, 4.1.0, 4.2.0 Dec 10, 2020
@st0012 st0012 modified the milestones: 4.2.0, 4.3.0 Jan 27, 2021
@st0012 st0012 removed this from the 4.3.0 milestone Mar 2, 2021
@st0012
Copy link
Collaborator

st0012 commented Jun 11, 2021

Write events to disk before attempting to send, so that they can be retried in the event of a temporary network failure. Needs to implement a cap on the number of stored events.

This is mostly useful on mobile clients where connectivity is often not available.

@rhcarvalho based on the document, I think this is for mobile SDKs? and AFAIK, the current server side SDK practice is to drop the event when failed to avoid flooding users' disk?

@rhcarvalho
Copy link
Contributor

Right, disk buffer is not part of most SDKs, and when it is I think the fundamental reason to have it is to be able to report events after a crash (for example, mobile apps), and not to retry failed requests.
Such kind of feature could escalate to distributed system problems (https://en.wikipedia.org/wiki/Thundering_herd_problem, https://en.wikipedia.org/wiki/TCP_global_synchronization).

@st0012
Copy link
Collaborator

st0012 commented Jun 11, 2021

@rhcarvalho thanks for quick response and the references 👍
I'll close this then.

@st0012 st0012 closed this as completed Jun 11, 2021
4.x automation moved this from To do to Done Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.x
  
Done
Development

No branches or pull requests

3 participants