Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Heroku, SERVER_NAME should equal $DYNO #703

Closed
nateberkopec opened this issue Jul 3, 2017 · 1 comment
Closed

On Heroku, SERVER_NAME should equal $DYNO #703

nateberkopec opened this issue Jul 3, 2017 · 1 comment
Milestone

Comments

@nateberkopec
Copy link
Contributor

https://devcenter.heroku.com/articles/dynos#local-environment-variables

Maybe if $DYNO is present, we can just hook that up automatically. I wonder what a sane way to detect if we're on Heroku would be? Look for env variables with HEROKU in them? Look for a .heroku folder? Or is the presence of DYNO fine?

@nateberkopec
Copy link
Contributor Author

Although probably a "private API" in a sense, we could check for the presence of /etc/heroku, which we already do to get the release.

@nateberkopec nateberkopec added this to the 2.7.0 milestone Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant