Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ThreadsInterface #1178

Merged
merged 2 commits into from
Jan 15, 2021
Merged

Add ThreadsInterface #1178

merged 2 commits into from
Jan 15, 2021

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Jan 2, 2021

In an exception event

It now has a new thread section.

截圖 2021-01-02 下午10 18 17

In a message event

It now has a new thread section + stacktrace.

截圖 2021-01-02 下午10 18 57

In a transaction event

Transaction events don't contain threads info.

closes #551

@st0012 st0012 added this to the 4.2.0 milestone Jan 2, 2021
@st0012 st0012 requested a review from HazAT January 2, 2021 14:22
@st0012 st0012 self-assigned this Jan 2, 2021
@st0012 st0012 added this to In progress in 4.x via automation Jan 2, 2021
@codecov-io
Copy link

codecov-io commented Jan 2, 2021

Codecov Report

Merging #1178 (ca265f6) into master (17e8ce8) will increase coverage by 0.61%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1178      +/-   ##
==========================================
+ Coverage   97.98%   98.59%   +0.61%     
==========================================
  Files         192       98      -94     
  Lines        8170     4400    -3770     
==========================================
- Hits         8005     4338    -3667     
+ Misses        165       62     -103     
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/client.rb 96.42% <100.00%> (+0.27%) ⬆️
sentry-ruby/lib/sentry/event.rb 98.90% <100.00%> (+0.05%) ⬆️
sentry-ruby/lib/sentry/interface.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/interfaces/threads.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/client_spec.rb 96.88% <100.00%> (+0.36%) ⬆️
...ntry-raven/lib/raven/core_ext/object/duplicable.rb
...ven/lib/raven/breadcrumbs/active_support_logger.rb
sentry-raven/lib/raven/transports.rb
sentry-raven/lib/raven/client.rb
sentry-raven/lib/raven/processor/cookies.rb
... and 91 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17e8ce8...ca265f6. Read the comment docs.

@st0012 st0012 force-pushed the threads-interface branch 4 times, most recently from 5d6b7e4 to bb75304 Compare January 8, 2021 10:25
@st0012 st0012 force-pushed the threads-interface branch 2 times, most recently from ca265f6 to af1949b Compare January 15, 2021 11:18
@st0012 st0012 changed the base branch from master to 4-2 January 15, 2021 11:19
@st0012 st0012 merged commit 3d2342b into 4-2 Jan 15, 2021
4.x automation moved this from In progress to Done Jan 15, 2021
@st0012 st0012 deleted the threads-interface branch January 15, 2021 11:32
st0012 added a commit that referenced this pull request Jan 17, 2021
* Add ThreadsInterface

* Update changelog
st0012 added a commit that referenced this pull request Feb 3, 2021
* Add ThreadsInterface (#1178)

* Add ThreadsInterface

* Update changelog

* Inspect exception cause by default & don't exclude ActiveJob::DeserializationError  (#1180)

* Turn on inspect_exception_causes_for_exclusion by default

With this config turned on, we can avoid matching the surface exceptions
in integrations, which could cause issues like #1071.

Solves #642.

* Remove ActiveJob::DeserializationError from ignored list

Since the previous commit solves #642, this commit can remove
ActiveJob::DeserializationError from the ignored exceptions list.

Solves #1071.

* Update async document

* Update changelog

* Make sentry-rails a Rails engine and provide default job class for async (#1181)

* Make sentry-rails a Rails engine too

* Add Sentry::SendEventJob

Instead of letting users defining their SentryJob class, we should
provide a default job class for them.

* Update document and example for the new job class

* Update changelog

* Add configuration option for trusted proxies (#1126)

* Add configuration option for trusted proxies

* Add `trusted_proxies` configuration option to sentry-ruby
* Add existing ActionDispatch `trusted_proxies` values

* Address some PR feedback

* Isolate trusted proxy test configuration
* Add comments to explain why we reverse the forwarded_for ip list
* Call `uniq` on the trusted proxy list
* Rename `filter_local_addresses(ips) to filter_trusted_proxy_addresses(ips)

* Remove duplicated hash entry

* Update some tests after PR feedback

* retrigger checks

Co-authored-by: Stan Lo <[email protected]>

* Only define SendEventJob when ActiveJob is defined

* Allow users to configure ActiveJob adapters to ignore (#1256)

* Allow users to configure ActiveJob adapters to ignore

* Update changelog

* Add sidekiq adapter to sentry-rails' ignored adapters list (#1257)

* Add sidekiq adapter to sentry-rails' ignored adapters list

* Update changelog

* Tag queue name and jid on sidekiq events (#1258)

* Add queue name and jid to event tags

* Update changelog

* Tag job_id and provider_job_id on ActiveJob events (#1259)

* Refactor/test ActiveJob's context data

* Tag job_id and provider_job_id on ActiveJob events

* Update changelog

* Add ability to have many post initialization callbacks (#1261)

* Add ability to have many post initialization callbacks

* Revert version bumping, fix codestyle and rewrite rspec test

* Remove dependenciy bumping from sentry-sidekiq

* Add entries to CHANGELOG

* Support config.before_breadcrumb (#1253)

* Support config.before_breadcrumb

Example:

```
config.before_breadcrumb = lambda do |breadcrumb, hint|
  breadcrumb.message = "foo"
  breadcrumb
end
```

* Update changelog

* Update sentry-ruby's changelog

* Update sentry-rails' changelog

* Update sentry-sidekiq's changelog

* Rename ignored_active_job_adapters to skippable_job_adapters (#1264)

* Update sentry-ruby's changelog

Co-authored-by: Jon-Erik Schneiderhan <[email protected]>
Co-authored-by: Valentine Kiselev <[email protected]>
st0012 added a commit that referenced this pull request Feb 3, 2021
* Add ThreadsInterface

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.x
  
Done
Development

Successfully merging this pull request may close these issues.

Support Threads interface
2 participants