Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log envelope delivery message with debug instead of info #2320

Merged
merged 2 commits into from
Jun 9, 2024

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Jun 9, 2024

This reduces the noise for most users.

Also deletes the log_info helper as now it's not used anymore.

#closes #2315

This reduces the noise for most users.

Also deletes the `log_info` helper as now it's not used anymore.
@st0012 st0012 self-assigned this Jun 9, 2024
Copy link

codecov bot commented Jun 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.67%. Comparing base (7b00b25) to head (f8b38d0).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2320   +/-   ##
=======================================
  Coverage   98.66%   98.67%           
=======================================
  Files         205      205           
  Lines       13422    13484   +62     
=======================================
+ Hits        13243    13305   +62     
  Misses        179      179           
Components Coverage Δ
sentry-ruby 99.04% <100.00%> (+0.01%) ⬆️
sentry-rails 97.41% <ø> (-0.02%) ⬇️
sentry-sidekiq 97.01% <ø> (+0.02%) ⬆️
sentry-resque 96.79% <ø> (+0.03%) ⬆️
sentry-delayed_job 98.92% <ø> (+<0.01%) ⬆️
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-ruby/lib/sentry/transport.rb 99.04% <100.00%> (ø)
sentry-ruby/lib/sentry/utils/logging_helper.rb 100.00% <ø> (ø)
sentry-ruby/spec/sentry/rake_spec.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/transport_spec.rb 100.00% <ø> (ø)

... and 33 files with indirect coverage changes

@st0012 st0012 requested a review from sl0thentr0py June 9, 2024 22:04
@st0012 st0012 merged commit 389395e into master Jun 9, 2024
124 checks passed
@st0012 st0012 deleted the implement-#2315 branch June 9, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't log every envelope as info
2 participants