Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure prevent bug to be sent #2260

Closed
ppascualv opened this issue Mar 11, 2024 · 4 comments
Closed

Ensure prevent bug to be sent #2260

ppascualv opened this issue Mar 11, 2024 · 4 comments
Assignees

Comments

@ppascualv
Copy link

ppascualv commented Mar 11, 2024

Issue Description

When ensure is used the exception halted between the begin and ensure block is not sent to Sentry

Reproduction Steps

def foo
  raise "error"
ensure
  puts "Ensure"
end

Expected Behavior

Send raised error to Sentry

Actual Behavior

The error is not sent

Ruby Version

3.1.1

SDK Version

5.16

Integration and Its Version

Rails, Sidekiq, same version

Sentry Config

config.dsn = Rails.application.credentials.sentry.dsn unless Rails.env.test?
config.breadcrumbs_logger = [:active_support_logger, :sentry_logger, :http_logger]
config.environment = Rails.env
config.enabled_environments = %w[production staging].freeze
config.send_modules = false
config.max_breadcrumbs = 15
config.traces_sample_rate = 0.2

@sl0thentr0py
Copy link
Member

@ppascualv is this in some rails code or in plain ruby somewhere in a script.
If it's plain ruby, you'll need a manual Sentry.capture_exception call.

@ppascualv
Copy link
Author

it's rails

@sl0thentr0py
Copy link
Member

cannot repro, so I will need repro steps from you to investigate further.

with the following controller:
sl0thentr0py/sentry_sample_apps@d587d41#diff-4390d009262006d4b3916229bab087f2bd24aacc3a088b52a876c56ded21ef2f

I got this issue

image

@getsantry
Copy link

getsantry bot commented Apr 2, 2024

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Apr 2, 2024
@getsantry getsantry bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants