-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sentry-shoryuken #2237
Labels
Comments
did you find a work around for this? |
I've added my own middleware. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the idea
Same as sidekiq and delayed_job: provide an integration for shoryuken, so that errors are OOTB reported.
Why do you think it's beneficial to most of the users
shoryuken
is by far the most used SQS framework in ruby. A lot of ruby applications are integrated in, or integrate with components deployed in AWS. It only makes sense to make this more streamlined.Possible implementation
shoryuken
was initially forked fromsidekiq
, so it has a fairly similar architecture, with the same middleware system used bysentry-sidekiq
to manage its integration. From that point of view, I believe it should be straightforward to implement.The text was updated successfully, but these errors were encountered: