Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning in sentry-sidekiq: Sidekiq exception handlers now take three arguments #2157

Closed
rnestler opened this issue Nov 1, 2023 · 1 comment · Fixed by #2160
Closed
Assignees

Comments

@rnestler
Copy link

rnestler commented Nov 1, 2023

Issue Description

sentry-sidekiq triggers the following deprecation warning from sidekiq: Sidekiq exception handlers now take three arguments.

Context:

Reproduction Steps

Use sidekiq 7.1.6

Expected Behavior

Don't trigger deprecation warning.

Actual Behavior

Triggers deprecation warning.

Ruby Version

3.2.2

SDK Version

5.12.0

Integration and Its Version

Sidekiq 7.1.6

Sentry Config

No response

@natikgadzhi
Copy link
Contributor

@sl0thentr0py, I didn't mean to be rude or arrogant — was just looking for issues to play around with, and pushed up this: #2160

But, totally fair and no hard feelings if you'd rather do this on your own and/or differently! Hope the PR helps and saves you a few minutes 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants