-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup initialize/close behavior to prevent initialized? checks everywhere #2096
Comments
The eventual goal is to find a way to limit the number of
And just having this change wouldn't reduce any of those checks as we usually do So to actually achieve the goal, we need to ensure the data flow is not interrupted after
It'd avoid all the |
And perhaps we should implement a better version of
close
andSentry.initialize?
馃Specifically:
@background_worker
and@session_flusher
Sentry.initialize?
is backed by a simple boolean state that's changed bySentry.ini
andSentry.close
.We would still need
Sentry.initialize?
in some places to stop some actions after the SDK is closed, but we don't need it for preventingnil
value anymore, which is getting out of hand IMO.Originally posted by @st0012 in #2084 (comment)
The text was updated successfully, but these errors were encountered: