Fix puma integration for versions before v5 #2141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2141 +/- ##
=======================================
Coverage 97.29% 97.30%
=======================================
Files 97 97
Lines 3627 3630 +3
=======================================
+ Hits 3529 3532 +3
Misses 98 98
|
Older versions of puma only takes 2 arguments for the `Puma::Server#lowlevel_error` method, so we need to pass the right number of arguments when calling `super` depending on the puma version.
sl0thentr0py
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older versions of puma only takes 2 arguments for the
Puma::Server#lowlevel_errormethod, so we need to pass the right number of arguments when callingsuperdepending on the puma version.Closes #2067