Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if the SDK is Rack 3 compatible #1761

Closed
st0012 opened this issue Mar 14, 2022 · 1 comment
Closed

Check if the SDK is Rack 3 compatible #1761

st0012 opened this issue Mar 14, 2022 · 1 comment
Projects

Comments

@st0012
Copy link
Collaborator

st0012 commented Mar 14, 2022

Rack 3 is on its way and will include multiple breaking changes. We should check if the SDK & its tests need any change for it.

@st0012 st0012 added this to To do in 5.x via automation Mar 14, 2022
@st0012
Copy link
Collaborator Author

st0012 commented Apr 23, 2022

Upgrading to Rack 3 will cause multiple errors in the sentry-rails test suite. But I think the cause is between Rack 3 <-> Rails and have opened an PR for it: rack/rack#1876

Update: The issue is an intentional spec change on Rack and Rails will need to update its implementation for it. So there's nothing we can do about it.

With that being said, both Sinatra and Rails lock their rack at 2.*, so we won't need to actively watch Rack 3's release until they also push a big release for Rack 3 support (which can take months). I'll close this for now.

cc @sl0thentr0py

@st0012 st0012 closed this as completed Apr 23, 2022
5.x automation moved this from To do to Done Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5.x
Done
Development

No branches or pull requests

1 participant