-
-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a "request body" size option for HTTP request logging #1633
Comments
@awei82 I'm not sure about defining size options as there's no standard for that. what do you think about using byte length instead? for example, the current size is config.request_body_size = 4096 |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
@st0012 sorry for the slow response - having the request body option be a size is totally fine with me. Thanks! |
Describe the idea
Add a "request body" size configuration option for HTTP request logging, basically identical to this implementation: https://docs.sentry.io/platforms/python/guides/logging/configuration/options/#request-bodies
Why do you think it's beneficial to most of the users
It'll allow us to control the size of the request body being logged. We want log request bodies, but also want to avoid capturing huge data blobs.
Possible implementation
This could probably be a straight port from the Python implementation from the link above.
The text was updated successfully, but these errors were encountered: