Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "request body" size option for HTTP request logging #1633

Closed
awei82 opened this issue Nov 30, 2021 · 3 comments
Closed

Add a "request body" size option for HTTP request logging #1633

awei82 opened this issue Nov 30, 2021 · 3 comments
Projects

Comments

@awei82
Copy link

awei82 commented Nov 30, 2021

Describe the idea
Add a "request body" size configuration option for HTTP request logging, basically identical to this implementation: https://docs.sentry.io/platforms/python/guides/logging/configuration/options/#request-bodies

Why do you think it's beneficial to most of the users
It'll allow us to control the size of the request body being logged. We want log request bodies, but also want to avoid capturing huge data blobs.

Possible implementation
This could probably be a straight port from the Python implementation from the link above.

@awei82 awei82 changed the title Add a "request body" size configuration option for HTTP request logging Add a "request body" size option for HTTP request logging Nov 30, 2021
@st0012
Copy link
Collaborator

st0012 commented Nov 30, 2021

@awei82 I'm not sure about defining size options as there's no standard for that. what do you think about using byte length instead? for example, the current size is 4096 * 4 and you may only want 4096, so you just use it like:

config.request_body_size = 4096

@st0012 st0012 added this to To do in 4.x via automation Nov 30, 2021
@github-actions
Copy link

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

4.x automation moved this from To do to Done Dec 28, 2021
@awei82
Copy link
Author

awei82 commented Jan 3, 2022

@st0012 sorry for the slow response - having the request body option be a size is totally fine with me. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.x
  
Done
Development

No branches or pull requests

2 participants