Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sentry-rails depends on rails > 5 and so breaks custom/minimal Rails Gemfile #1263

Closed
christos opened this issue Feb 2, 2021 · 1 comment
Assignees
Projects

Comments

@christos
Copy link

christos commented Feb 2, 2021

Describe the bug

The sentry-rails gem depends on Rails and so brings in all of the Rails gems, even if the host project's Gemfile only requires a minimal set of gems

To Reproduce

Run bundle install using a Gemfile like so:

gem "activerecord", "~> 6.1.1"
gem "actionmailer", "~> 6.1.1"
gem "actionpack", "~> 6.1.1"

gem "sentry-ruby"
gem "sentry-rails"

Expected behavior

Only activerecord,actionmailer, and actionpack are installed from Rails

Actual behavior

All Rails gems are brought in

Environment

  • Ruby Version: 2.7.2
  • SDK Version:
    • sentry-ruby (4.1.5)
  • Integration Versions (if any):
    • sentry-rails (4.1.7)

I think the sentry-rails gem should warn and fail gracefully when the parts of Rails it needs are missing, but not actually require Rails itself.

@st0012 st0012 added this to To do in 4.x via automation Feb 18, 2021
@st0012
Copy link
Collaborator

st0012 commented Feb 18, 2021

I think the sentry-rails gem should warn and fail gracefully when the parts of Rails it needs are missing, but not actually require Rails itself.

I disagree with this. since the gem is called sentry-rails, it makes sense to specify rails as a dependency. manually checking each component's presence would increase the maintenance effort significantly. I understand the use case of minimal Rails apps, but we don't have the resource to break the support down to individual components' level.

@st0012 st0012 closed this as completed Feb 18, 2021
4.x automation moved this from To do to Done Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.x
  
Done
Development

No branches or pull requests

2 participants