Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a requirement-free version of sentry-ruby #1201

Closed
st0012 opened this issue Jan 13, 2021 · 3 comments
Closed

Add a requirement-free version of sentry-ruby #1201

st0012 opened this issue Jan 13, 2021 · 3 comments

Comments

@st0012
Copy link
Collaborator

st0012 commented Jan 13, 2021

We're seeing users that are tied with older versions of faraday, which prevents them from using the sentry-ruby SDK. The reason we bumped the faraday requirement to >= 1.0 was because earlier versions of it (before 0.17.3) will cause warnings or even crash when used with Ruby 2.7 & 3.0.

But if the user uses Ruby 2.4~2.6, it's actually safe for them to use earlier versions of faraday like 0.15 or 0.16. So we should provide an option for these usages as well.

Solution

Add a sentry-ruby-core gem, which doesn't specify any version of faraday

# sentry-ruby-core.gemspec
spec.add_dependency "faraday"

and then wrap sentry-ruby around it with faraday >= 1.0

# sentry-ruby.gemspec
spec.add_dependency "sentry-ruby-core", Sentry::VERSION
spec.add_dependency "faraday", ">= 1.0"
@st0012 st0012 self-assigned this Jan 13, 2021
@st0012 st0012 added this to To do in 4.x via automation Jan 13, 2021
@st0012 st0012 added this to the 4.1.5 milestone Jan 21, 2021
@Drewzar
Copy link

Drewzar commented Jan 21, 2021

Thanks for this!

Will updates becoming to sentry-rails and sentry-sidekiq that have the option to use the core version as well?

@st0012 st0012 modified the milestones: 4.1.5, sentry-ruby-4.1.5 Jan 27, 2021
@st0012
Copy link
Collaborator Author

st0012 commented Jan 27, 2021

@Drewzar we'll make the change in the next release after we're sure sentry-ruby 4.1.5 works without any issue 🙂

@st0012
Copy link
Collaborator Author

st0012 commented Jan 28, 2021

@Drewzar fyi both sentry-rails and sentry-sidekiq depend on sentry-ruby-core now 🙂

@st0012 st0012 closed this as completed Jan 28, 2021
4.x automation moved this from To do to Done Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.x
  
Done
Development

No branches or pull requests

2 participants