-
-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a requirement-free version of sentry-ruby #1201
Comments
Thanks for this! Will updates becoming to |
@Drewzar we'll make the change in the next release after we're sure |
This was referenced Jan 28, 2021
@Drewzar fyi both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We're seeing users that are tied with older versions of
faraday
, which prevents them from using thesentry-ruby
SDK. The reason we bumped thefaraday
requirement to>= 1.0
was because earlier versions of it (before0.17.3
) will cause warnings or even crash when used with Ruby 2.7 & 3.0.But if the user uses Ruby 2.4~2.6, it's actually safe for them to use earlier versions of
faraday
like0.15
or0.16
. So we should provide an option for these usages as well.Solution
Add a
sentry-ruby-core
gem, which doesn't specify any version of faradayand then wrap sentry-ruby around it with
faraday >= 1.0
The text was updated successfully, but these errors were encountered: