Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate rack integration #1138

Merged
merged 5 commits into from
Dec 16, 2020
Merged

Separate rack integration #1138

merged 5 commits into from
Dec 16, 2020

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Dec 11, 2020 •
edited

Rack integration should be optional. This PR makes sure non-Rack applications can still use this SDK without any issue.

closes #1136

@st0012 st0012 added this to the 4.0.1 milestone Dec 11, 2020
@st0012 st0012 self-assigned this Dec 11, 2020
@st0012 st0012 added this to In progress in 4.x via automation Dec 11, 2020
@st0012 st0012 force-pushed the separate-rack-integration branch 3 times, most recently from 499c456 to ff977f2 Compare December 11, 2020 14:59
@codecov-io
Copy link

codecov-io commented Dec 11, 2020 •
edited

Codecov Report

Merging #1138 (51e19bf) into master (e7b78ab) will increase coverage by 0.40%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1138      +/-   ##
==========================================
+ Coverage   97.68%   98.09%   +0.40%     
==========================================
  Files         189       95      -94     
  Lines        7781     3981    -3800     
==========================================
- Hits         7601     3905    -3696     
+ Misses        180       76     -104
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/interfaces/request.rb 97.36% <ø> (-0.64%) ⬇️
sentry-ruby/lib/sentry-ruby.rb 97.29% <100.00%> (+0.11%) ⬆️
sentry-ruby/lib/sentry/rack.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/rack/interface.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/scope.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/event_spec.rb 100.00% <100.00%> (ø)
...y/spec/sentry/interfaces/request_interface_spec.rb 100.00% <100.00%> (ø)
...ry-ruby/spec/sentry/rack/capture_exception_spec.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/rack/tracing_spec.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/scope/setters_spec.rb 96.66% <100.00%> (ø)
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7b78ab...51e19bf. Read the comment docs.

@st0012 st0012 modified the milestones: 4.0.1, 4.0.2 Dec 11, 2020
@st0012 st0012 modified the milestones: 4.0.2, 4.1.0 Dec 16, 2020
@st0012 st0012 merged commit 87c03f0 into master Dec 16, 2020
4.x automation moved this from In progress to Done Dec 16, 2020
@st0012 st0012 deleted the separate-rack-integration branch December 16, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@st0012 st0012

Labels
None yet
Projects
4.x
  
Done
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

LoadError when using sentry-ruby in a non-rack environment
2 participants
@st0012 @codecov-io