Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sentry-delayed_job #1129

Closed
st0012 opened this issue Dec 10, 2020 · 8 comments · Fixed by #1273
Closed

Add sentry-delayed_job #1129

st0012 opened this issue Dec 10, 2020 · 8 comments · Fixed by #1273

Comments

@st0012
Copy link
Collaborator

st0012 commented Dec 10, 2020

No description provided.

@booleanbetrayal
Copy link

Are there any updates to the status of sentry-delayed_job? It's currently blocking our adoption of the new sentry-ruby migration. Thanks for any info in advance!

@st0012 st0012 added this to To do in 4.x via automation Jan 26, 2021
@st0012
Copy link
Collaborator Author

st0012 commented Jan 29, 2021

I'll try to make a beta version of it in the upcoming weekend 🙂

@dan-jensen
Copy link

@st0012 would you mind elaborating in the issue description? I'm just not sure what this issue represents.

According to the Sentry documentation: "For common environments and frameworks like Rails, Rack, and others [including DelayedJob], we provide automatic integration for reporting." But after upgrading from sentry-raven to sentry-ruby, I've found that exceptions raised in the DelayedJob context are NOT being reported to Sentry. Does this issue capture the reason why?

@st0012
Copy link
Collaborator Author

st0012 commented Feb 5, 2021

the document you point to is for the old sentry-raven SDK. the new sentry-ruby currently doesn't support capturing errors in DelayedJob because the integration gem sentry-delayed_job is still a work in progress (which is what this issue is for).

@dan-jensen
Copy link

@st0012 you are awesome – thank you for the explanation, and even more for PR #1273 🙇

@st0012
Copy link
Collaborator Author

st0012 commented Feb 6, 2021

I've added the gem in #1273. I think it should be working now, but I want to gather some feedback before releasing it. can anyone give it a try and tell me what can be improved 🙂

you can install it with

gem "sentry-delayed_job", github: "getsentry/sentry-ruby", branch: "sentry-delayed_job"

@dan-jensen
Copy link

@st0012 just followed your instructions and it's working in Rails 6.1.1 on Ruby 2.6.3. (Specifically, it's calling Sentry.capture_exception when an exception is raised in the DelayedJob context.) No deprecation warnings either. Nicely done, thanks so much! 🎉

4.x automation moved this from To do to Done Feb 9, 2021
@st0012
Copy link
Collaborator Author

st0012 commented Feb 10, 2021

sorry for the long-waiting everyone, we've just released sentry-delayed_job yesterday 😄
although it relies on sentry-ruby 4.2.0, 4.2.0 doesn't require any extra setup compared with migrating to 4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.x
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants