Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ClickHouse integration work with django-clickhouse-backend #3095

Open
sentrivana opened this issue May 22, 2024 · 0 comments
Open

Make ClickHouse integration work with django-clickhouse-backend #3095

sentrivana opened this issue May 22, 2024 · 0 comments
Labels

Comments

@sentrivana
Copy link
Contributor

sentrivana commented May 22, 2024

Problem Statement

The ClickHouse integration doesn't create spans if used in Django via django-clickhouse-backend.

This first surfaced in #3088 where the whole integration would error out because _sentry_span was not set on the connection as expected. We're patching the integration to not do anything if _sentry_span is not there, but it'd be good to have proper support for django-clickhouse-backend.

Solution Brainstorm

Looks like the spans are not started the expected way (clickhouse_driver.connection.Connection.send_query is not called?), so we might need to wrap an additional function that django-clickhouse-backend uses to start queries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant