Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maglnet/composer-require-checker in CI #1521

Closed
Jean85 opened this issue Apr 27, 2023 · 4 comments
Closed

Add maglnet/composer-require-checker in CI #1521

Jean85 opened this issue Apr 27, 2023 · 4 comments

Comments

@Jean85
Copy link
Collaborator

Jean85 commented Apr 27, 2023

Problem Statement

getsentry/sentry-symfony#714 (comment):

Btw, sentry/sentry has the same issue in GuzzleTracingMiddleware.

Solution Brainstorm

@cleptric we should avoid similar issues in the future by adding https://packagist.org/packages/maglnet/composer-require-checker in CI

Originally posted by @Jean85 in getsentry/sentry-symfony#714 (comment)

We can also use https://packagist.org/packages/irstea/composer-require-checker-shim if we don't want to pollute our dependencies.

@Jean85
Copy link
Collaborator Author

Jean85 commented Apr 27, 2023

Same as getsentry/sentry-symfony#716

@ste93cry
Copy link
Collaborator

ste93cry commented Apr 27, 2023

The GuzzleTracingMiddleware class is not used by this package and it was provided mostly as an example for the tracing feature itself. I don't think we should require a package used by it if the class itself is optional. Besides that, I'm totally favourable to use maglnet/composer-require-checker in general 👍

@cleptric
Copy link
Member

There is indeed nothing to be fixed here. The GuzzleTracingMiddleware requires the Guzzle HTTP client to work, so there is no need to construct the URI dynamically.

Adding the require checker might be worth doing.

@cleptric
Copy link
Member

With 4.0 I think we're good here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants