-
-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not register the error handler if the DSN is null #1190
Comments
Currently, there are 3 methods that register an handler of some kind: exceptions, errors, fatals
All 3 of them are used ONLY in the relative integration:
So, removing those 3 integrations from the building of the init, it should be enough to avoid the error handler active at all. Or am I missing something? |
Looking at the code I think you're right, if the DSN is Edit: |
I have two opposing views on this:
|
Yes, that's the main reason to release this as a bugfix rather than an improvement so that that issue does not have to wait too long yet to be fixed
I don't see a real problem with this, this is how a lot of things work: they are disabled in development and are enabled only in production |
Any news regarding this? Just setup a new Symfony 5.3 project for some legacy code and ran into this when running some integration tests I wrote: 3974d77b1b62:/var/www/symfony# php ./vendor/bin/phpunit
PHPUnit 9.5.10 by Sebastian Bergmann and contributors.
... 3 / 3 (100%)
Time: 00:01.697, Memory: 52.50 MB
OK (3 tests, 7 assertions)
THE ERROR HANDLER HAS CHANGED!
3974d77b1b62:/var/www/symfony# |
This comment was marked as outdated.
This comment was marked as outdated.
bump |
From my side, yes, absolutely this is something it's time to work on. I know @Jean85 had a different opinion on the solution, but the way it works now is just causing so many headaches and troubles that it's not worth it in my opinion. |
Related to getsentry/sentry-symfony#46 (comment)
The text was updated successfully, but these errors were encountered: