Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checkInId in Sentry.withMonitor #9648

Closed
danilofuchs opened this issue Nov 23, 2023 · 5 comments · May be fixed by #9654
Closed

checkInId in Sentry.withMonitor #9648

danilofuchs opened this issue Nov 23, 2023 · 5 comments · May be fixed by #9654
Labels
Feature: Crons Meta: Help Wanted Type: Improvement

Comments

@danilofuchs
Copy link

Problem Statement

Would be nice to be able to set our own id for a cron job execution, as we have a cross-referenceable uuid for that.

It is available under captureCheckIn({checkInId: ourId}) but not on withMonitor(name, handler)

Solution Brainstorm

Change the first parameter from name, to options, with both properties
@AbhiPrasad
Copy link
Member

@danilofuchs sounds like a good idea. PRs are welcome!

@danilofuchs
Copy link
Author

I'll send a PR soon!

@danilofuchs danilofuchs mentioned this issue Nov 25, 2023
Open
2 tasks
@lforst
Copy link
Member

lforst commented Nov 27, 2023

@AbhiPrasad Are we sure that this is a good idea? I think checkin ids should mostly be abstracted away when using withMonitor and that tags and contexts will be a better mechanism to associate other entities with a cron job...

@danilofuchs
Copy link
Author

@AbhiPrasad Are we sure that this is a good idea? I think checkin ids should mostly be abstracted away when using withMonitor and that tags and contexts will be a better mechanism to associate other entities with a cron job...

I agree tags and context would make much more sense!

@AbhiPrasad
Copy link
Member

Hey @danilofuchs - we created a GH issue to track adding tags/contexts to crons: getsentry/sentry#60741

please leave your thoughts there! For now I'm going to close this issue in favour of that.

@AbhiPrasad AbhiPrasad closed this as not planned Won't fix, can't repro, duplicate, stale Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature: Crons Meta: Help Wanted Type: Improvement
Projects
GitHub Issues with 👀
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cron): Custom checkInId danilofuchs/sentry-javascript
3 participants
@lforst @danilofuchs @AbhiPrasad