-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Sentry Developer Metrics #803
Comments
This comment was marked as outdated.
This comment was marked as outdated.
How important is it that aggregation occurs between the multiple processes? We can intercept the metrics envelopes sent from the renderers and pull out the array of My guess is that it wouldn't be that common to submit the same metrics from different processes anyway and we could just pass the metric envelopes straight through the main process, much like we do already for replay envelopes. |
I think this is required, given we want to minimize the amount of envelopes sent to Sentry as much as possible. I think Does an interval flushing mechanism work fine for electron? |
Actually I don't think we need to add a |
Problem Statement
Sentry is introducing support for a metrics product.
Spec: https://develop.sentry.dev/sdk/metrics/
This was already implemented in the JavaScript SDK:
Min required JS SDK version:
7.91.0
Solution Brainstorm
Let's add this to the Electron SDK!
This should be similar to the Node SDK, so we gate the usage by
metricsAggregator
experiment.I think the Electron Client can just use the server-runtime metrics aggregator, the renderer can just forward to the main process, and the main process client is in charge of the aggregation.
The text was updated successfully, but these errors were encountered: