Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs are not saved in the event on a native crash #802

Closed
3 tasks done
michalzaq12 opened this issue Dec 21, 2023 · 4 comments · Fixed by #812
Closed
3 tasks done

Breadcrumbs are not saved in the event on a native crash #802

michalzaq12 opened this issue Dec 21, 2023 · 4 comments · Fixed by #812
Assignees

Comments

@michalzaq12
Copy link

Is there an existing issue for this?

How do you use Sentry?

Sentry Saas (sentry.io)

Electron SDK Version

4.15.1

Electron Version

26.0.0

What platform are you using?

Windows

Link to Sentry event

No response

Steps to Reproduce

.

Expected Result

The event breadcrumb context should be the same as when the error occurred.

Actual Result

Breadcrumbs are not saved in the event on a native crash, which causes incorrect application context and makes debugging difficult.
image
image

@timfish
Copy link
Collaborator

timfish commented Dec 21, 2023

What tags was this event sent with?

The Electron SDK has offline support so that if sending of events fails, they are retried later which can give a time difference between occurrence and received.

@timfish timfish self-assigned this Dec 21, 2023
@michalzaq12
Copy link
Author

Tags:
image

The Electron SDK has offline support so that if sending of events fails, they are retried later which can give a time difference between occurrence and received.

I understand, but when you try to send the event again, the context (breadcrumbs) should not be overwritten.

@timfish
Copy link
Collaborator

timfish commented Dec 21, 2023

event.process: browser suggests that this minidump was picked up at application startup. Crashes in the Electron main process (browser) cause the application to terminate so we send these on next app start using saved context if there is any.

It looks like the breadcrumbs there are from the subsequent app start. I'll need to look into this.

@timfish
Copy link
Collaborator

timfish commented Jan 7, 2024

When updating the Electron SDK to use the latest Sentry JavaScript SDKs, I simplified how the scope is applied to events.

I added some extra breadcrumbs to the native main tests (#812) and they appear to be as expected so the scope changes might have fixed whatever issues there were before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants