Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing util.promise shim in context.ts #64

Closed
hibiyasleep opened this issue Apr 17, 2018 · 3 comments
Closed

missing util.promise shim in context.ts #64

hibiyasleep opened this issue Apr 17, 2018 · 3 comments

Comments

@hibiyasleep
Copy link

hibiyasleep commented Apr 17, 2018 •
edited

src/context.ts didn't require util.promisify/shim, unlike src/uploader.ts do.

because of this, this moudle doesn't work on electron 1.8.x and/or below.
@timfish
Copy link
Collaborator

timfish commented Apr 17, 2018

I'm using the latest release in Electron 1.8.4 without any issues. What error are you getting?

@jan-auer jan-auer mentioned this issue Apr 17, 2018
Merged
@jan-auer
Copy link
Member

Will be published with the next release today.

@hibiyasleep
Copy link
Author

hibiyasleep commented Apr 18, 2018 •
edited

@timfish I'm using 1.7.x, and util.promisify doesn't exist since it uses node 7.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timfish @jan-auer @hibiyasleep