feat: Migrate to Node context #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
Apr 3, 2024
|
For some reason the tests for v15.5.7 on ubuntu pass but the process hangs at the end and doesn't exit 😭 |
|
Stale promise somewhere? might be useful to throw a https://www.npmjs.com/package/why-is-node-running at it and see what gets logged out. Side note - can we max times for the tests? Ideally we don't use 5 hours for the runner, we can just cancel the tests after 30 min. |
Yeah it looks like you can set a timeout for actions steps and 25m should be plenty. |
|
I have no idea how I managed to merge this. I didn't click anything and all the tests weren't passing. I enabled auto merge earlier today 🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #525
Closes #603
This PR migrates to using device context mostly supplied by the
nodeContextIntegrationrather than the similar implementation that it was originally forked from in the Electron SDK.This PR:
languagetoculturecontext (Add support for Culture Context #525)user.ip_address: '{{auto}}'which should not be included by default (user.ip_addressshould not be set to{{auto}}#603)event_typetag which was replaced withevent.environmentin v4mainContextIntegrationhas been removed and replaced by:electronContextIntegrationwhich both adds Electron context and removes Node context which is not appropriatenormalizePathsIntegrationwhich normalises all paths