Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minidump is not picked up after webContents.forcefullyCrashRenderer() #591

Closed
timfish opened this issue Nov 18, 2022 · 1 comment · Fixed by #592
Closed

Minidump is not picked up after webContents.forcefullyCrashRenderer() #591

timfish opened this issue Nov 18, 2022 · 1 comment · Fixed by #592
Assignees

Comments

@timfish
Copy link
Collaborator

timfish commented Nov 18, 2022

As per this comment, cc @Cefold

After webContents.forcefullyCrashRenderer() event, there was a minidump under pending folder, but it seems that Sentry cannot find it. It will upload it until next app restart, thus event.process will be classified as browser instead of renderer.

It looks like this is caused by the fact that the minidump ends up in the pending directory until the app restarts on macOS.

@timfish
Copy link
Collaborator Author

timfish commented Nov 18, 2022

It's worth noting that Electrons behaviour here differs between platforms.

  • On Windows and Linux forcefullyCrashRenderer() results in { reason: 'crashed' } with the minidump in the regular location
  • On macOS forcefullyCrashRenderer() results in { reason: 'exited' } with the minidump in the pending directory

This means on Windows and Linux there is no way to determine if a minidump came from a regular crash or a forced crash. One possible way to mitigate this would be to manually set tags before calling forcefullyCrashRenderer.

@timfish timfish self-assigned this Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant