-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using source maps, not showing original code #54
Comments
Can you provide a link to the event from your Sentry account? |
@kamilogorek it's on a docker instance. Can you get access to docker instances? Otherwise I can make you an account |
JSON: https://pastebin.com/P1nz9Enn Artifacts (text version): https://pastebin.com/Pvqc2iyL |
We've been having issues with uploading Electron symbols and we can't upload breakpad files onto our Docker instance and I was led to the conclusion that 8.22 is too old and a new release would fix the issue (getsentry/sentry#7804). |
@DimitarNestorov, thanks for providing more context. From what you are saying, it seems you are having two issues. Let's start with JavaScript code context and source maps. It seems that you're uploading the right source maps, but they are missing the
After that, the paths of your source maps on the releases page should match the ones in the issue exactly (or actually, you should start seeing the resolved source files). Let me know if that does not work, as I'm currently investigating an issue with source maps in renderer processes. Regarding native debug information files (Electron symbols). You do not need to upload Electron symbols for JavaScript support, they are only required for native crashes. Unfortunately, even if you could upload those symbols, 8.22 does not yet have the capability of dealing with native crashes. Let's continue that discussion in getsentry/sentry#7804. |
@DimitarNestorov are those all the artifacts that you upload? If so, then you missed all the source files :) We need a 1 to 1 This is how browsers work as well. What we do is we take a look at each stacktrace's frame and pull out the culprit file, let's say What most likely happens here is that we are not able to find the source file itself, so the system is not able to understand what's it's sourcemap file is (as there's nothing that stops you from having a sourcecode in |
Thanks @kamilogorek for the explanation. You were right, I need to upload both the |
Great investigation and solution :) This was exactly our problem too! <3 |
hi @DimitarNestorov as you replied this: |
@kamilogorek I believe @chj-damon meant to mention you instead of me |
I've solved this problem. it is because something went wrong in the docker. |
@chj-damon 兄弟可以私聊一下怎么解决的吗,我这边也是涉及到docker镜像,正确上传了js和map文件却没办法回溯代码 |
Hi I have faced a similar issue, only I don't have a git repo integration. I am trying to use the local repo as for now. The source files and the source maps are uploaded to artifacts but I still can't see the original code in the error event. I really need help! |
If someone needs any more info or wants to see how I am using a dummy repo to check, you may ask. I am ready to provide info. |
I am using the 3 below variables and then executing them in a js file const associate_commits = const script = |
At this point I checked all the possible things I could do wrong and even the #SourceMappingURLs are fine. IT IS FROM A CREATE REACT APP.the build on generation are g-zipped |
@Dipesh-Das97 Hi, do you resolve that problem? |
@vidt6 you can use sentry-cli now to understand if/what went wrong. See first section https://docs.sentry.io/platforms/javascript/sourcemaps/troubleshooting_js/ |
@kamilogorek it's more of a query. In my application I can see the source maps pointing towards the exact code however for some cases I don't see the source map even available. I think all the source maps are uploaded properly and it still is not detecting the actual error. Sentry is initialised at the root of the app. Can you share any suggestions? |
Ah, sorry, I dont know exactly how electron-sdk is setup, you'll need to create a new issue for that. |
@kamilogorek it is for a react JS setup not electron. |
@kamilogorek I don't know what is error. This is my script to upload source map to sentry |
@kamilogorek Can you tell me what the error is? Thanks a lot |
Well, it tries to find |
I cannot see this |
This is what your stacktrace frame points to, it's impossible for me to know how it's produced without seeing the codebase. |
Oh I know but it's the source of my company. Can you suggest me where to check this error? |
Yes |
Since this is close i have created new issue. (#567) and referred below. Please can you assist as to why we aren't see source map / original code. |
What I'm getting:
![image](https://user-images.githubusercontent.com/8790386/38312210-d3c7b860-3829-11e8-8235-eb21de4f9212.png)
What I'm expecting:
![image](https://user-images.githubusercontent.com/8790386/38312293-0fe45182-382a-11e8-8848-af52d26f6cf7.png)
I have uploaded the same source maps both with prefix
app:https:///build/
and~/
.The text was updated successfully, but these errors were encountered: