-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve size of dependencies #47
Comments
Looping in @kamilogorek @HazAT. I was wondering if we should just bundle |
As far as I understand it, most electron packagers by default simply to
# exclude all those build artifacts while ensuring we have the native binary
- "!**/node_modules/*/build/*"
- "**/node_modules/*/build/**/*.node"
# exclude some other native things
- "!**/node_modules/**/{*.cc,*.c,*.h,*.obj,*.pdb}" I haven't checked but assuming - "!**/node_modules/raven-js/dist/*"
- "**/node_modules/raven-js/dist/raven.js" But if the output of |
I think it makes more sense to just check in a build of |
Much improved by v0.5.0 release |
Most consumers of this library are not going to bundle it and its dependencies as they will access it directly from
node_modules
.Currently it adds around 8MB to the app size and over 1MB to the compressed installer sizes of an empty Electron app.
It looks like we could save around 75% of this if we didn't have to include the whole of
raven-js/dist
.The text was updated successfully, but these errors were encountered: