Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getPath('userData') should only be evaluated when calling create #41

Closed
timfish opened this issue Mar 15, 2018 · 0 comments
Closed

getPath('userData') should only be evaluated when calling create #41

timfish opened this issue Mar 15, 2018 · 0 comments
Labels
Type: Bug

Comments

@timfish
Copy link
Collaborator

timfish commented Mar 15, 2018

const CACHE_PATH = join(getApp().getPath('userData'), 'sentry');

Gets evaluated when the library is required/imported rather than when create is called.

If developers change the userData directory after importing but before calling create the cache path can be incorrect.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timfish