Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'crashed' event is deprecated as of Electron 8.4 #246

Closed
3 tasks
jleongDialpad opened this issue Jul 14, 2020 · 1 comment · Fixed by #247
Closed
3 tasks

'crashed' event is deprecated as of Electron 8.4 #246

jleongDialpad opened this issue Jul 14, 2020 · 1 comment · Fixed by #247

Comments

@jleongDialpad
Copy link

Versions + Platform

Description

Electron 8.4.0 has deprecated the 'crashed' event in favour of 'render-process-gone'. The new event gives finer detail over why the render process disappeared

Added new render-process-gone event on app to replace the renderer-process-crashed event. #24314
Added new render-process-gone event to replace the crashed event. #24308

https://www.electronjs.org/releases/stable?version=8#release-notes-for-v840

Notes of deprecation:
https://www.electronjs.org/docs/api/web-contents#event-crashed-deprecated

This event is superceded by the render-process-gone event which contains more information about why the render process dissapeared. It isn't always because it crashed. The killed boolean can be replaced by checking reason === 'killed' when you switch to that event.

Current sentry-electron version handle the event here:

contents.on('crashed', async () => {

To support older and present versions the proposed update would be to handle both crashed and render-process-gone event here.

@HazAT
Copy link
Member

HazAT commented Jul 15, 2020

We will fix this in the next version :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants