Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support electron 7 #198

Merged
merged 2 commits into from
Dec 5, 2019
Merged

feat: Support electron 7 #198

merged 2 commits into from
Dec 5, 2019

Conversation

Richienb
Copy link
Contributor

Closes #193

@Richienb
feat: Support electron 7
25c7f60 
Signed-off-by: Richie Bendall <[email protected]>
@timfish
Copy link
Collaborator

timfish commented Nov 30, 2019

Thanks for this.

I think we're going to have to do some fudging/merging with the type definitions from multiple Electron versions to get this compiling.

@Richienb Richienb marked this pull request as ready for review December 1, 2019 04:53
@Richienb
Copy link
Contributor Author

Richienb commented Dec 1, 2019

@timfish I've just done that. The build is now passing.

@HazAT
Copy link
Member

HazAT commented Dec 5, 2019

Cool thx!

@HazAT HazAT merged commit 04d014f into getsentry:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timfish timfish timfish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Usages of app.getName() display warning in Electron v7
3 participants
@Richienb @timfish @HazAT