Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Electron v6-7 #194

Merged
merged 15 commits into from
Nov 19, 2019
Merged

Fix: Electron v6-7 #194

merged 15 commits into from
Nov 19, 2019

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Nov 15, 2019 •
edited
Loading

  • Add issue template
  • Update dependencies
  • Fix linting issues
  • Update and add all Electron versions for e2e tests
  • Stop allowing test failures on Windows
  • Use single instance of TestServer for all tests
  • Use crashpad logic for Electron >= v6 on Windows
  • Use node-fetch rather than electron-fetch
  • Use win-ca to load Windows root CA's to give same behaviour as electron-fetch
  • Use Sentry logger to trace some caught exceptions

Fixes #192, Fixes #176 and Fixes #144

@timfish timfish requested a review from HazAT November 15, 2019 00:47
@timfish
Copy link
Collaborator Author

timfish commented Nov 18, 2019 •
edited
Loading

No idea why the Windows tests are not passing. The output suggests the tests have exited correctly and then mentions that it's failed due to no output:

image

HazAT
HazAT approved these changes Nov 19, 2019
View reviewed changes
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

src/common.ts Outdated Show resolved Hide resolved
@HazAT HazAT merged commit f2df31e into master Nov 19, 2019
@HazAT HazAT deleted the fix/native branch November 19, 2019 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazAT HazAT HazAT approved these changes

@jan-auer jan-auer Awaiting requested review from jan-auer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@timfish @HazAT